Convert IFRT's kString dtype to NumPy's variable length string dtype. #32274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=80&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_813472617
branch
from
fa57a4d to
c5b0de5
Compare
Previously, `xla::ifrt::DType::kString` would be translated to `NPY_OBJECT`. NumPy 2.0 has introduced a variable length string type, `NPY_VSTRING`, so convert to that when available. This is consistent with `xla::DtypeToIfRtDType`, which performs the opposite translation. PiperOrigin-RevId: 813472617
copybara-service
bot
force-pushed
the
test_813472617
branch
from
c5b0de5 to
2508dd3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert IFRT's kString dtype to NumPy's variable length string dtype.
Previously,
xla::ifrt::DType::kStringwould be translated toNPY_OBJECT. NumPy 2.0 has introduced a variable length string type,NPY_VSTRING, so convert to that when available. This is consistentwith
xla::DtypeToIfRtDType, which performs the opposite translation.